Implement Mempool

[exdx]

Port the Mempool type and API from avalanchego. See https://pkg.go.dev/github.com/ava-labs/[email protected] for package-level documentation.

[exdx]

https://pkg.go.dev/github.com/ava-labs/[email protected]/vms/platformvm/txs/mempool

[exdx]

See https://github.com/ava-labs/avalanchego/pull/1958/files#diff-fc671b8b3c30328876f4984afaaf43b548dd28cc886934a95a0fbcdb6788f1ae for an example of the new gossipable set interface which will be used by avalanchego VMs via the SDK in the future. The solution should likely implement this interface to be compatible.

[Sanghren]

I'm interested in contributing (at least have a try) to this ticket. Before I start, I have a question regarding the directory structure for the implementation.

In avalanchego, the relevant code is located in vms/platformvm/txs/mempool . Should the equivalent code in avalanche-rs be placed in core/vms/platformvm/txs/mempool?

I'm asking because I noticed that the peer code in avalanchego is in network/peer, whereas in avalanche-rs, it's in core/network/src/peer.

I'd like to ensure I'm placing my contributions in the correct directories.

[exdx]

Thanks for looking into this.

In avalanchego historically, each vm has their own mempool implementation, leading to a lot of code duplication. We are working to provide a common library for APIs like mempool (see ava-labs/avalanchego#1958 for an example of a mempool API called Gossipable).

I think for now the best thing to do would be to implement a Gossipable trait, along with other traits in the above PR. We would like to have parity with the latest avalanchego APIs.

We can put it in https://github.com/ava-labs/avalanche-rs/tree/main/core/network/src under a p2p module for now.

[Sanghren]

I have some stuff ongoing over here : https://github.com/Sanghren/avalanche-rs/tree/add_gossipable. Not sure about everything I did though.

[exdx]

I have some stuff ongoing over here : https://github.com/Sanghren/avalanche-rs/tree/add_gossipable. Not sure about everything I did though.

That's great. I would open a PR and then we can take a look. It can be a draft PR if not's not fully ready.

[Sanghren]

Opened a draft PR here : #45