Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFA path generation returns no coordinates for splitpoint #1038

Closed
leon-wagner opened this issue Oct 22, 2024 · 0 comments · Fixed by #1039
Closed

DFA path generation returns no coordinates for splitpoint #1038

leon-wagner opened this issue Oct 22, 2024 · 0 comments · Fixed by #1039
Labels
bug Something isn't working

Comments

@leon-wagner
Copy link
Contributor

leon-wagner commented Oct 22, 2024

When generating dfa path, coordinate information for the splitpoint is not generated. Returns following error message.
File "...\shpConversion.py", line 478, in writePoint2SHPfile
if len(pointDict['x']) > 1 or len(pointDict['y']) > 1:
^^^^^^^^^^^^^^^^^^^
TypeError: object of type 'numpy.float64' has no len()

@leon-wagner leon-wagner added the bug Something isn't working label Oct 22, 2024
@leon-wagner leon-wagner changed the title DFA path generation returns no .prj for splitpoint DFA path generation returns no coordinates for splitpoint Oct 22, 2024
@leon-wagner leon-wagner linked a pull request Oct 22, 2024 that will close this issue
6 tasks
leon-wagner added a commit that referenced this issue Nov 28, 2024
…t or other)

- adjustment to writePoint2SHPfile to account for pytest. tested and it still fixes the addressed problem.
fso42 pushed a commit that referenced this issue Dec 5, 2024
…t or other)

- adjustment to writePoint2SHPfile to account for pytest. tested and it still fixes the addressed problem.
fso42 pushed a commit that referenced this issue Dec 9, 2024
- com1 overrides moved from runScript to ini

- new --runDFA flag logic

- path is generated from fields by default (resType changed accordingly)

- moved runScript to main avaframe folder (for QGIS)

- clean DFAPath output folder in avadir before generating path (necessary for QGIS, so if script is run multiple times, paths that are previously generated are not returned to QGIS)

- removed coulomb friction and other com1 overrides, path is now generated from standard run

- added option to add velocity info when FV is saved

set splitpoint to be generated at the top of path if it is not found, instead of not at all (avoids issues with QGIS)

- adjusted corresponding error message

- accordingly adjusted plot generation to exclude splitPoints set at the top

general changes to DFAPath output plots

- add missing discrete color levels for Travel Angle and changed it from a mix of lapaz and batlow to nuuk color map
- grey out faulty legend plotting line thereby removing user warning: “no artists found with label”… in log and removes empty legend in top right corner of birds eye view panel
- more descriptive runDFA flag comment in runScript

- set dt to 1

fixes #1038, adds extra checks for what type is expected (point, float or other)

- adjustment to writePoint2SHPfile to account for pytest. tested and it still fixes the addressed problem.

- adjusted runDFAModule flag, added to ini
- renamed functions in DFAPathGeneration.py to reflect better what they do
fso42 pushed a commit that referenced this issue Dec 9, 2024
- com1 overrides moved from runScript to ini

- new --runDFA flag logic

- path is generated from fields by default (resType changed accordingly)

- moved runScript to main avaframe folder (for QGIS)

- clean DFAPath output folder in avadir before generating path (necessary for QGIS, so if script is run multiple times, paths that are previously generated are not returned to QGIS)

- removed coulomb friction and other com1 overrides, path is now generated from standard run

- added option to add velocity info when FV is saved

set splitpoint to be generated at the top of path if it is not found, instead of not at all (avoids issues with QGIS)

- adjusted corresponding error message

- accordingly adjusted plot generation to exclude splitPoints set at the top

general changes to DFAPath output plots

- add missing discrete color levels for Travel Angle and changed it from a mix of lapaz and batlow to nuuk color map
- grey out faulty legend plotting line thereby removing user warning: “no artists found with label”… in log and removes empty legend in top right corner of birds eye view panel
- more descriptive runDFA flag comment in runScript

- set dt to 1

fixes #1038, adds extra checks for what type is expected (point, float or other)

- adjustment to writePoint2SHPfile to account for pytest. tested and it still fixes the addressed problem.

- adjusted runDFAModule flag, added to ini
- renamed functions in DFAPathGeneration.py to reflect better what they do
PaulaSp3 pushed a commit that referenced this issue Dec 16, 2024
- com1 overrides moved from runScript to ini

- new --runDFA flag logic

- path is generated from fields by default (resType changed accordingly)

- moved runScript to main avaframe folder (for QGIS)

- clean DFAPath output folder in avadir before generating path (necessary for QGIS, so if script is run multiple times, paths that are previously generated are not returned to QGIS)

- removed coulomb friction and other com1 overrides, path is now generated from standard run

- added option to add velocity info when FV is saved

set splitpoint to be generated at the top of path if it is not found, instead of not at all (avoids issues with QGIS)

- adjusted corresponding error message

- accordingly adjusted plot generation to exclude splitPoints set at the top

general changes to DFAPath output plots

- add missing discrete color levels for Travel Angle and changed it from a mix of lapaz and batlow to nuuk color map
- grey out faulty legend plotting line thereby removing user warning: “no artists found with label”… in log and removes empty legend in top right corner of birds eye view panel
- more descriptive runDFA flag comment in runScript

- set dt to 1

fixes #1038, adds extra checks for what type is expected (point, float or other)

- adjustment to writePoint2SHPfile to account for pytest. tested and it still fixes the addressed problem.

- adjusted runDFAModule flag, added to ini
- renamed functions in DFAPathGeneration.py to reflect better what they do
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant