Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional input dir for aimec analysis #896

Merged
merged 8 commits into from
Aug 22, 2023
Merged

add optional input dir for aimec analysis #896

merged 8 commits into from
Aug 22, 2023

Conversation

awirb
Copy link
Contributor

@awirb awirb commented Aug 17, 2023

  • add optional input directory where to look for files for aimec analysis
  • add option to create mass plot if only one sim
  • fix axes label in mass plot
  • add relTh .asc files for fetchInputData function

@awirb awirb requested a review from fso42 August 17, 2023 08:22
@fso42 fso42 added the enhancement New feature or request label Aug 17, 2023
@fso42 fso42 added this to the Version 1.7 milestone Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 65.51% and project coverage change: +0.02% 🎉

Comparison is base (5d72afe) 73.68% compared to head (a24311d) 73.70%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   73.68%   73.70%   +0.02%     
==========================================
  Files          63       63              
  Lines       14408    14446      +38     
==========================================
+ Hits        10616    10648      +32     
- Misses       3792     3798       +6     
Files Changed Coverage Δ
avaframe/in1Data/getInput.py 87.63% <0.00%> (-1.30%) ⬇️
avaframe/ana3AIMEC/aimecTools.py 81.65% <75.00%> (-0.13%) ⬇️
avaframe/ana3AIMEC/ana3AIMEC.py 68.57% <75.00%> (-0.18%) ⬇️
avaframe/ana3AIMEC/dfa2Aimec.py 84.11% <100.00%> (ø)
avaframe/out3Plot/outAIMEC.py 84.94% <100.00%> (+0.05%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fso42 fso42 modified the milestones: Version 1.7, Version 1.6 Aug 22, 2023
Copy link
Contributor

@fso42 fso42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, please add a description of the filenames for the AIMEC analysis.

docs/moduleAna3AIMEC.rst Outdated Show resolved Hide resolved
docs/moduleAna3AIMEC.rst Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Aug 22, 2023

Code Climate has analyzed commit a24311d and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 67.8% (50% is the threshold).

This pull request will bring the total coverage in the repository to 73.7% (0.1% change).

View more on Code Climate.

@fso42 fso42 merged commit 9d0ef65 into master Aug 22, 2023
3 checks passed
@fso42 fso42 deleted the makeAimecGen branch August 22, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants