Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registerCompletionHandler to main.d.cts #3307

Closed
wants to merge 1 commit into from

Conversation

sosnovsky
Copy link

In 6.1.1 release it's not possible to use registerCompletionHandler in CommonJS project.
This PR adds registerCompletionHandler to main.d.cts, so it can be imported in CommonJS

Fixes #3306.

@novemberborn
Copy link
Member

Thank you for the thorough PR @sosnovsky.

The lack of CJS here is intentional. Mostly to avoid polluting the default export, which is shared with ESM. Also because usage ought to be rare enough that you can work around it in CJS using dynamic import.

@sosnovsky
Copy link
Author

Got it, thanks for explanation, will try to use it through dynamic import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

registerCompletionHandler can't be used in CommonJS project
2 participants