Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light theme is applied to dark-themed applications when the system theme is light #21

Open
workonfire opened this issue Aug 4, 2022 · 2 comments

Comments

@workonfire
Copy link

As the title says. I can see why this happens, but I'd like to use some apps with a dark theme while the system theme stays light.

Expected behavior:

System theme is light, while in apps where the theme should be dark, this extension should use the dark variant instead of the light one.
For example, there's Tilix where I have the dark theme explicitly enabled.
With my green wallpaper and global light theme enabled, it should look like this:
image
image

Current behavior:

image
image

Also, the contrast in dropdown menus is a bit odd.

@allaeddineomc
Copy link

the solution will be for the extension to generate both a dark and a light style sheets instead of a single one and setting it ts the theme , this will also fix the apps not switching dark and light themes till they are closed and reopened

@sidevesh
Copy link

sidevesh commented Sep 4, 2022

I looked into this issue and @allaeddineomc seems to be right, generating both dark and light style sheets would solve this issue for a lot of apps which have manual dark and light mode toggles including the new Gnome text editor, Gnome Console and others,
@avanishsubbiah I also saw GradienceTeam/Gradience#12 which might be relevant for this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants