Base location coordinates starting at [1, 1]

[MatejKastak]

I suggest basing location.column to the number 1 (e.g. start counting from 1).

How text editors do it?

I did some research and here are the results (most of the programs are in the default configuration).

• Top leftmost character is at index [line, column]:

1. Index: [1, 1]

• vscode
• atom
• vim
• sublime text
• nano
• joe

2. Index: [1, 0]

• emacs

Implementation notes

• I think its kind of implemented here

  yaramod/include/yaramod/parser/location.h

  Line 89 in 17144b6

  Position begin() const { return {_begin.line, _begin.column + 1}; }

  , but I it should be implemented on the parser level in order to ensure consistency. This +1 could lead to surprising results.
• Can potentially solve String location coordinates should start at the $ symbol #126