Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support special characters in schema name #124

Open
Tracked by #1703
mahalakshme opened this issue Feb 20, 2025 · 4 comments
Open
Tracked by #1703

Support special characters in schema name #124

mahalakshme opened this issue Feb 20, 2025 · 4 comments
Assignees
@himeshr @ombhardwajj

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Feb 20, 2025 •
edited
Loading

AC:

Fix this issue by supporting special chars., in schema name

Technical discussion notes:

We can support whatever postgres supports and restrict only wherever it doesn't
@mahalakshme mahalakshme moved this to In Analysis in Avni Product Feb 20, 2025
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Feb 20, 2025
@ombhardwajj ombhardwajj self-assigned this Feb 20, 2025
@ombhardwajj ombhardwajj moved this from Ready to In Progress in Avni Product Feb 20, 2025
@ombhardwajj
Copy link
Member

Commit link
9ee33eb

@ombhardwajj ombhardwajj moved this from In Progress to Code Review Ready in Avni Product Feb 20, 2025
@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Feb 20, 2025
@petmongrels petmongrels moved this from In Code Review to QA Ready in Avni Product Feb 20, 2025
@mahalakshme mahalakshme mentioned this issue Feb 21, 2025
Open
9 tasks
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Feb 21, 2025
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Feb 24, 2025
@AchalaBelokar AchalaBelokar moved this from Done to QA Failed in Avni Product Feb 27, 2025
@AchalaBelokar
Copy link

AchalaBelokar commented Feb 27, 2025 •
edited by himeshr
Loading

Reopened card, as app breaks when user checks the DisplayCount button in RWB GDGS25-26UAT MediaViewer app and then does a search

@vinayvenu vinayvenu reopened this Feb 27, 2025
@github-project-automation github-project-automation bot moved this from QA Failed to Triaged in Avni Product Feb 27, 2025
@mahalakshme mahalakshme moved this from Triaged to QA Failed in Avni Product Feb 28, 2025
@himeshr himeshr self-assigned this Feb 28, 2025
@himeshr himeshr moved this from QA Failed to In Progress in Avni Product Feb 28, 2025
himeshr added a commit that referenced this issue Feb 28, 2025
@himeshr
#124 | Enclose all schemaName place-holder's within double-quotes
15a0327
himeshr added a commit that referenced this issue Feb 28, 2025
@himeshr
Revert "#124 | Enclose all schemaName place-holder's within double-qu…
874d02b 
…otes"

This reverts commit 15a0327.
himeshr added a commit that referenced this issue Feb 28, 2025
@himeshr
#124 | Enclose schemaName within double-quotes in countMedia query
35c2f45
@himeshr himeshr moved this from In Progress to QA Ready in Avni Product Feb 28, 2025
@himeshr
Copy link
Contributor

himeshr commented Feb 28, 2025

Dev Testing done

  • Confirmed that fresh ETL run after droping etl for 'gdgs25-26uat' org was completed successfully.
  • Media-viewer search with and without "Display count" selected and with / without filters works as expected

himeshr added a commit that referenced this issue Feb 28, 2025
@himeshr
#124 | Update delete_etl_metadata_for_schema and delete_etl_metadata_…
e2bcc90 
…for_org to handle schemaNames with hiphen
himeshr added a commit to avniproject/avni-server that referenced this issue Feb 28, 2025
@himeshr
avniproject/avni-etl#124 | Update delete_etl_table_metadata, delete_e…
da70cd1 
…tl_metadata_for_schema and delete_etl_metadata_for_org to handle schemaNames with hiphen
@himeshr
Copy link
Contributor

himeshr commented Feb 28, 2025

Code changes in Avni-server and Avni-etl repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@himeshr himeshr

@ombhardwajj ombhardwajj

Labels
None yet
Projects
Avni Product
Status: QA Ready
Milestone
No milestone
Development

No branches or pull requests
5 participants
@vinayvenu @mahalakshme @himeshr @AchalaBelokar @ombhardwajj