Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading user and catchments not working with voided entries #756

Closed
sachsk opened this issue Jul 15, 2024 · 1 comment
Closed

Uploading user and catchments not working with voided entries #756

sachsk opened this issue Jul 15, 2024 · 1 comment

Comments

@sachsk
Copy link
Member

sachsk commented Jul 15, 2024

Describe the bug

I am not able to upload the user & catchment via CSV getting error "query did not return a unique result" .

Root cause:

In implementation there are 2 groups with same name and one is voided.
In the code, we're checking for groups by name, and it seems there are two groups with the same name, causing the code to break. check here

AC:

Technical:

  1. Update the code to consider only non-voided groups, catchment.

For address levels and sync concepts it is working currently since we rename the name on voiding.

voided or fetching

Analysis points(Ignore):

  • Should be able to create a dashboard with the same name as voided one avni-webapp#1209 - Why do we change the name when something is voided - it is for the users to know and hence it is applicable only for transactional data and not for metadata, since we dont show the voided metadata anywhere right? Also changing the name will require migration for existing data.
  • Too many cases to handle because of voided data(bundle upload etc.,) - Why cant we hard delete metadata?
  • Or should we just rename and run migrations so that we need not handle at mutiple places
  • or handle at repository level in all places?
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Jul 15, 2024
@mahalakshme mahalakshme moved this from New Issues to In Analysis in Avni Product Jul 17, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Jul 17, 2024
@mahalakshme mahalakshme changed the title Not able to upload user & catchment CSV Uploading user and catchments not working with voided groups Jul 17, 2024
@mahalakshme mahalakshme changed the title Uploading user and catchments not working with voided groups Uploading user and catchments not working with voided entries Jul 17, 2024
@mahalakshme
Copy link
Contributor

will be fixed as part of avniproject/avni-webapp#858

@github-project-automation github-project-automation bot moved this from In Analysis Review to Done in Avni Product Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants