Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to access offline report cards under App designer #1054

Closed
4 tasks
nupoorkhandelwal opened this issue Oct 3, 2023 · 2 comments
Closed
4 tasks

Unable to access offline report cards under App designer #1054

nupoorkhandelwal opened this issue Oct 3, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@nupoorkhandelwal
Copy link
Contributor

nupoorkhandelwal commented Oct 3, 2023

Describe the bug
As an org admin user, i am currently unable to access the offline report card though i can edit it!

To Reproduce
Steps to reproduce the behavior:

  1. Go to Pre release - APF
  2. Click on App designer
  3. Scroll down to "Offline report cards"
  4. Click on any one of them and see the error

Screenshots

Image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Analysis details

  • This happens when report card is clicked and Icon is not added for the report card and it returns 500.
Screenshot 2023-10-03 at 5 24 49 PM - The above issue is happening in prod as well like in the above image but it doesn't block the user from using the webapp. Currently in prerelease it blocks the user from using the app, since we have added the check for hostname as part of security fixes.

Acceptance criteria

  • Call to fetch the icon need not happen unless there is an icon url returned from the report card url.
  • Test by adding icon.

Developer Checklist(Developer fixing the bug should fill this checklist)

  • Does the fix require extensive regression testing?
    • Yes
    • No
  • Are you mentioning the required scenarios that could be affected?
    • Yes
    • No
@nupoorkhandelwal nupoorkhandelwal added the bug Something isn't working label Oct 3, 2023
@nupoorkhandelwal nupoorkhandelwal moved this to New Issues in Avni Product Oct 3, 2023
@mahalakshme mahalakshme moved this from New Issues to In Analysis in Avni Product Oct 3, 2023
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Oct 3, 2023
@ashusvnath ashusvnath moved this from Ready to In Progress in Avni Product Oct 3, 2023
@ashusvnath ashusvnath moved this from In Progress to QA Ready in Avni Product Oct 3, 2023
@1t5j0y 1t5j0y moved this from QA Ready to In QA in Avni Product Oct 4, 2023
@1t5j0y
Copy link
Contributor

1t5j0y commented Oct 4, 2023

QA Notes:

  1. Works as expected. Report card screen loads fine if icon is an empty string.
  2. Super admin users access to report cards is blocked if icon is a valid s3 uri. (The GET /media/signedUrl call fails with a 500 "Access is denied" error and the page errors out) - this probably needs a different card. If there is no icon set for the report card, it loads fine. FYI @vinayvenu @mahalakshme

@mahalakshme
Copy link
Contributor

@1t5j0y yes, that can be moved to a separate card. can you create a card for it. I think few other things also dont work for super admin as expected. We can add them as and when we find out.

@1t5j0y 1t5j0y moved this from In QA to Done in Avni Product Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants