-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEA] Multiselect media support #1133
Comments
Suggesting detailed acceptance criteria to ensure testing does not miss flows. Example: Where
Testing notes
|
@vinayvenu I can add the test cases that you have mentioned and few more, but I mentioned everything in the same card, because everything is somewhat interrelated.
May be I ll do the below:
|
…ave as single file upload inline with earlier behaviour
https://prerelease.avniproject.org/#/app/editSubject?uuid=4efeb844-d49f-42e0-b399-b85597b94fcf&type=curator Extended video: https://drive.google.com/file/d/1BLfSWFqURXrP5y8s9X2xQZvPY-i7Mf6Z/view?usp=drive_link Screen.Recording.2024-04-03.at.3.33.51.PM.mov |
Create / edit form test cases for Image and Video type formElements
|
…ss to questionGroupObservation
Only code review commits made since card was moved to "QA Failed" lane. |
…upload file size is exceeded
@AchalaBelokar i have fixed this issue "If Image or video is larger than normal size clear message should be visible" |
@himeshr tested on web app with max size upload is showed |
…upload file size is exceeded (cherry picked from commit 5f2ca33)
Current status:
Video for the issue:
https://github.com/avniproject/avni-webapp/assets/10369963/f7e2baaf-fde9-455e-89af-e1fff72957b9
Acceptance criteria:
The below should work for Image concept, for video, move it to separate card, if it is difficult(retaining the current functionality). Just added all in the same card, thinking if it is just one day additional effort, then I suggest we can complete it.
--- when editing a form with a multiselect media concept,
--- I should be able to add an additional image to the existing list of media
--- I should be able to remove one image from the existing list of media
--- I should be able to do both the above together
--- When saving the form, each change mentioned above is handled correctly
--- If I do not save the form, then changes do not persist
--- when creating a form with a multiselect media concept, all the above criteria is fulfilled
media_viewing.pdf
Tech reasons:
Out of scope:
Test cases:
Old: ignore
----- When multiple files uploaded from mobile, they are not visible in DEA. For them, Additional images uploaded(via DEA/mobile) should be visible, on clicking the right arrow in the carousel that appears when clicking 'View Media'.
----- In the Profile tab, in View mode increase the height of carousel to triple that of current one. On clicking right arrow again here as well, users should be able to see consecutive images. And on clicking cross mark in top right currently unable to close the carousel, though it closes in Edit mode. This need to be fixed.
----- Remove the 'Open in New tab' option.
----- Carousel need to be applicable only for the media in that concept when clicked on View media. Currently it shows media across all concepts for that subject.
https://github.com/avniproject/avni-webapp/assets/10369963/7cdc3b85-f99b-471f-ae55-4d959ae4d0f4
----- downloads in carousel when uploaded via DEA, works fine when uploaded via mobile app. This need to be fixed.
The text was updated successfully, but these errors were encountered: