Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces in headers and locations needs to be truncated #1255

Closed
Tracked by #1588
mahalakshme opened this issue Jun 18, 2024 · 2 comments
Closed
Tracked by #1588

Spaces in headers and locations needs to be truncated #1255

mahalakshme opened this issue Jun 18, 2024 · 2 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Jun 18, 2024

This was erroring out because there was a space in the header 'Catchment Name '. And it took long time to figure out the issue.

AC:

  • Trim leading and trailing spaces in headers of Locations and 'Users and Catchments' upload.
    • As part of this card, we show error message stating 'Headers are incorrect. Kindly check the sample file'. But even before validating the headers, trim the trailing and leading spaces.
    • If after truncating if showing of error message like 'Headers are incorrect. Kindly check the sample file'. when not correct(If any extra column name is present or if any mandatory column is missing) is not done for Users and Catchments do the same.
  • Trim leading and trailing spaces of location names across location types, in location upload(when creating locations) - if not done this is leading to issues when specifying locations for creating catchments since the spaces need to be correctly mentioned
@mahalakshme mahalakshme converted this from a draft issue Jun 18, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Jun 18, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Ready in Avni Product Jul 4, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Jul 4, 2024
@petmongrels petmongrels self-assigned this Jul 4, 2024
@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Jul 5, 2024
petmongrels added a commit to avniproject/avni-server that referenced this issue Jul 5, 2024
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Jul 23, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Jul 23, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jul 31, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Jul 31, 2024
@Dinesh2019 Dinesh2019 self-assigned this Aug 2, 2024
@Dinesh2019 Dinesh2019 moved this from QA Ready to In QA in Avni Product Aug 2, 2024
@Dinesh2019
Copy link

When we upload the file for user and catchment i am getting the error stating that provide location does not exist in the avni but the location is already exist in the system.

Env : staging
org : Teststatus
user : dinesh@teststatus

steps to reproduce :

1.Login to the webapp
2.Downloaded the user and catchment sample file
3.Edit the file according to the location
4.Upload the file

Expected result : it should accept and create or it should show Headers are incorrect if the data is invalid
Actual : it shows the Provided Location does not exist in Avni. Please add it or check for spelling mistakes 'Karanataka,tel,sol,dol'

Sample files :

uploaded file
sample-usersAndCatchments (1).csv

error file :
errors-sample-usersAndCatchments (1)(1).csv

@Dinesh2019 Dinesh2019 moved this from In QA to QA Failed in Avni Product Aug 2, 2024
@petmongrels
Copy link
Contributor

This is not a bug as the address lineage needs to have space in between.
This fix is only for preceding and trailing space is any cell.

@petmongrels petmongrels moved this from In Progress to QA Ready in Avni Product Aug 8, 2024
@Dinesh2019
Copy link

We have changed the header for each header we are getting diff error message

error file :

errors-sample-usersAndCatchments (1) (1).csv

errors-sample-usersAndCatchments (3).csv

@Dinesh2019 Dinesh2019 moved this from In QA to QA Failed in Avni Product Aug 10, 2024
@petmongrels petmongrels moved this from Code Review Ready to QA Ready in Avni Product Sep 9, 2024
@mahalakshme
Copy link
Contributor Author

@petmongrels yeah I also didn't mean the in between spaces in the AC. So all the points in the AC applies.

@Dinesh2019
Copy link

  • Getting oops error when we got the failure.

Refer video :

Click here to watch video

@Dinesh2019 Dinesh2019 moved this from In QA to QA Failed in Avni Product Sep 11, 2024
@Dinesh2019 Dinesh2019 moved this from In QA to Done in Avni Product Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants
@petmongrels @vinayvenu @mahalakshme @Dinesh2019 and others