Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to easily change the dashboard section order #1374

Closed
Tracked by #1671
mahalakshme opened this issue Nov 11, 2024 · 9 comments
Closed
Tracked by #1671

Unable to easily change the dashboard section order #1374

mahalakshme opened this issue Nov 11, 2024 · 9 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Nov 11, 2024

Issue:

Screen.Recording.2024-11-11.at.4.53.47.PM.mov
  • On drag and drop of sections - when there are more than 2 sections - not reordered as expected
  • Looks like the order deduced for other sections are incorrect - check for report card as well

AC

  • Order of sections and report cards should be able to change by drag and drop
  • The same should work as configured in mobile app as well after sync
@mahalakshme mahalakshme converted this from a draft issue Nov 11, 2024
@mahalakshme mahalakshme moved this from In Analysis to Focus Items in Avni Product Nov 11, 2024
@mahalakshme mahalakshme added the good first issue Good for newcomers label Dec 12, 2024
@mahalakshme mahalakshme moved this from Focus Items to In Analysis in Avni Product Dec 12, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Dec 12, 2024
@adamsanadi6 adamsanadi6 self-assigned this Dec 12, 2024
@adamsanadi6 adamsanadi6 moved this from Ready to In Progress in Avni Product Dec 12, 2024
@Zek1t0
Copy link

Zek1t0 commented Dec 14, 2024

Hello, I’m interested in working on this issue. Could you confirm if it’s still available for someone to take? If you have any specific guidelines or suggestions for tackling this, please let me know. Thank you!

@adamsanadi6 adamsanadi6 moved this from In Progress to Code Review Ready in Avni Product Dec 15, 2024
@mahalakshme
Copy link
Contributor Author

@Zek1t0 no this is done.

@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Dec 16, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Dec 16, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Dec 16, 2024

@adamsanadi6 include this commit in 10.2 branch as well since the branch has been cut

@dinesh2096 dinesh2096 moved this from QA Ready to In QA in Avni Product Dec 16, 2024
@dinesh2096
Copy link

dinesh2096 commented Dec 16, 2024

Still we face the above mentioned issue

QA Reference video :

Click here to watch the video

@dinesh2096 dinesh2096 moved this from In QA to QA Failed in Avni Product Dec 16, 2024
@adamsanadi6 adamsanadi6 moved this from QA Failed to In Progress in Avni Product Dec 17, 2024
@adamsanadi6 adamsanadi6 moved this from In Progress to QA Ready in Avni Product Dec 17, 2024
@dinesh2096 dinesh2096 moved this from QA Ready to In QA in Avni Product Dec 17, 2024
@dinesh2096
Copy link

dinesh2096 commented Dec 17, 2024

  • When we try to shuffle the card at the first attempt it is not happening but second time it is working as expected.

Reference Video :

Click here to watch the video

@dinesh2096 dinesh2096 self-assigned this Dec 17, 2024
@dinesh2096 dinesh2096 moved this from In QA to QA Failed in Avni Product Dec 17, 2024
@mahalakshme
Copy link
Contributor Author

@dinesh2096 agreed during the first attempt also it should work as expected like happening during the second time.
cc: @adamsanadi6

@himeshr himeshr self-assigned this Dec 20, 2024
himeshr added a commit that referenced this issue Dec 20, 2024
Remove unnecessary iteration of array and validate indexes are within range
@himeshr
Copy link
Contributor

himeshr commented Dec 20, 2024

Tests to be done:

  • Re-ordering of Dashboard Sections
  • Re-ordering of Report Cards within a section

@himeshr himeshr moved this from QA Failed to Code Review Ready in Avni Product Dec 20, 2024
@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Dec 20, 2024
@petmongrels
Copy link
Contributor

lets write a unit test for this method.

@petmongrels petmongrels moved this from In Code Review to Code Review with Comments in Avni Product Dec 20, 2024
@himeshr himeshr moved this from Code Review with Comments to QA Ready in Avni Product Dec 20, 2024
@dinesh2096 dinesh2096 moved this from QA Ready to In QA in Avni Product Dec 20, 2024
@dinesh2096
Copy link

  • Tested by shuffle the card for the first attempt and validate in the cilent app
  • Tested by shuffle the card for the multiple time and validate in the cilent app
  • [ ]Added the new card and changed the order and validate in the cilent app
  • Removed the new card and changed the order and validate in the cilent app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

8 participants