Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of inputCategory while initializing Student Data for CodedConcepts #101

Closed
Tracked by #24
himeshr opened this issue Oct 27, 2023 · 1 comment
Closed
Tracked by #24

Comments

@himeshr
Copy link

himeshr commented Oct 27, 2023

In Glific forms, for selectable fields, user can either specify the "Option ID" or a case-insensitive "Option value" as the input.
Therefore, the Flow_result we received, could have the inputValue for CodedConcepts in a different case than that configured in the MappingMetadata table.

Probable Fix
To handle this, make use of inputCategory while initializing Student Data for CodedConcepts.
In DataExtractorService.getResultData(), map tuple of [inputCategory, inputValue] as the value, and while populating codedConcept observation use inputCategory, otherwise use inputValue everywhere else.

Acceptance Criteria

  • We should be able to sync students that have inputValue for CodeConcepts in different case than the expected one, by using inputCategory to do the mapping
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Oct 27, 2023
@himeshr himeshr added the LAHI label Oct 27, 2023
@himeshr himeshr moved this from New Issues to Ready in Avni Product Oct 27, 2023
@himeshr himeshr changed the title Make the CodeConcepts mapping logic case insensitive Make use of inputCategory while initializing Student Data for CodedConcepts Oct 27, 2023
@vinayvenu vinayvenu moved this from Ready to In Progress in Avni Product Nov 8, 2023
@vinayvenu
Copy link
Member

This was complete as part of #102

@vinayvenu vinayvenu moved this from In Progress to QA Ready in Avni Product Nov 8, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 8, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Nov 8, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to Code Review with Comments in Avni Product Nov 8, 2023
@AchalaBelokar AchalaBelokar moved this from Code Review with Comments to In Code Review in Avni Product Nov 8, 2023
@vinayvenu vinayvenu moved this from In Code Review to QA Ready in Avni Product Nov 8, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Nov 23, 2023
@mahalakshme mahalakshme removed the LAHI label Nov 28, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants