Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to Goonj Integration Error Reporting #122

Closed
himeshr opened this issue Apr 11, 2024 · 1 comment
Closed

Minor changes to Goonj Integration Error Reporting #122

himeshr opened this issue Apr 11, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@himeshr
Copy link

himeshr commented Apr 11, 2024

Problem 1

We encounter different kinds of error in Goonj-Avni integration, which results in a need to create new GoonjErrorTypes in DB.
Whenever we do this, it also needs a corresponding addition to GoonjErrorType Enum, which is a costly effort.

Solution 1

Make Goonj Error type name in ErrorRecordLog independent of GoonjErrorType Enum.

Problem 2

Salesforce Team needs to only know the latest error that is currently blocking the entity from getting synced to to the system.

Solution 2

Replace the ErrorRecordLog every time to ensure that the latest entry with most recent error loggedAt dateTime is retained in the system

@himeshr himeshr self-assigned this Apr 11, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product Apr 11, 2024
@himeshr himeshr added the enhancement New feature or request label Apr 11, 2024
himeshr added a commit that referenced this issue Apr 11, 2024
@himeshr himeshr moved this from New Issues to Code Review Ready in Avni Product Apr 11, 2024
@himeshr himeshr moved this from Code Review Ready to In Progress in Avni Product Apr 11, 2024
@himeshr himeshr changed the title Make Goonj Error type name in ErrorRecordLog independent of GoonjErrorType Enum Minor changes to Goonj Integration Error Reporting Apr 11, 2024
himeshr added a commit that referenced this issue Apr 11, 2024
…t entry with most recent error loggedAt dateTime is retained in the system
@himeshr himeshr moved this from In Progress to Code Review Ready in Avni Product Apr 11, 2024
himeshr added a commit that referenced this issue Apr 11, 2024
…he latest entry with most recent error loggedAt dateTime is retained in the system"

This reverts commit aca8b5b.
himeshr added a commit that referenced this issue Apr 11, 2024
@himeshr
Copy link
Author

himeshr commented Apr 11, 2024

@vinayvenu Tests work as expected, but in prod, the first errorRecordLog is the one returned by ErrorRecord.getLastErrorRecordLog(), which is a problem in general for all integration systems. Unable to figure out why.?

Screenshot 2024-04-11 at 7 32 18 PM

himeshr added a commit that referenced this issue Apr 12, 2024
@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Apr 12, 2024
@petmongrels petmongrels moved this from In Code Review to QA Ready in Avni Product Apr 12, 2024
@himeshr himeshr moved this from QA Ready to Done in Avni Product Apr 15, 2024
himeshr added a commit that referenced this issue May 6, 2024
vinayvenu pushed a commit that referenced this issue May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants