forked from avni-bahmni-integration/integration-service
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor changes to Goonj Integration Error Reporting #122
Labels
enhancement
New feature or request
Comments
himeshr
changed the title
Make Goonj Error type name in ErrorRecordLog independent of GoonjErrorType Enum
Minor changes to Goonj Integration Error Reporting
Apr 11, 2024
himeshr
added a commit
that referenced
this issue
Apr 11, 2024
…t entry with most recent error loggedAt dateTime is retained in the system
himeshr
added a commit
that referenced
this issue
Apr 11, 2024
…he latest entry with most recent error loggedAt dateTime is retained in the system" This reverts commit aca8b5b.
himeshr
added a commit
that referenced
this issue
Apr 11, 2024
@vinayvenu Tests work as expected, but in prod, the first errorRecordLog is the one returned by ErrorRecord.getLastErrorRecordLog(), which is a problem in general for all integration systems. Unable to figure out why.? |
vinayvenu
added a commit
that referenced
this issue
Apr 23, 2024
himeshr
added a commit
that referenced
this issue
May 6, 2024
vinayvenu
pushed a commit
that referenced
this issue
May 16, 2024
… avoid sending healthcheck fail jobs
vinayvenu
pushed a commit
that referenced
this issue
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem 1
We encounter different kinds of error in Goonj-Avni integration, which results in a need to create new GoonjErrorTypes in DB.
Whenever we do this, it also needs a corresponding addition to GoonjErrorType Enum, which is a costly effort.
Solution 1
Make Goonj Error type name in ErrorRecordLog independent of GoonjErrorType Enum.
Problem 2
Salesforce Team needs to only know the latest error that is currently blocking the entity from getting synced to to the system.
Solution 2
Replace the ErrorRecordLog every time to ensure that the latest entry with most recent error loggedAt dateTime is retained in the system
The text was updated successfully, but these errors were encountered: