Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce redundant code #5745

Closed
wants to merge 0 commits into from
Closed

Conversation

TTz0601
Copy link
Contributor

@TTz0601 TTz0601 commented Aug 9, 2023

Reduce redundant code
Improve readability

@mr-avocado
Copy link

mr-avocado bot commented Aug 9, 2023

Dear contributor,
Avocado is currently under sprint #103, which is due to release an LTS (Long Term Stability) release.
Please avoid merging changes that do not fall into these categories:

  • Bug fixes
  • Usability Improvements
  • Documentation updates

As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality,
but changes to the existing APIs (including interface and behavior) should be avoided.
These kind of changes should wait until sprint #104.

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @TTz0601, I appreciate your effort in implementing these changes. It LGTM.

The only thing that needs attention is the signature. In the "git log" records, the author is displayed as zuohanxu <[email protected]>, while the commit message carries the signature TTz0601 <[email protected]>. It seems that there's a discrepancy in the signatures used between your system settings and the commit messages. Could you please align these signatures for consistency? Thank you for your cooperation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants