Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideas for middleware. #17

Open
pksjce opened this issue Apr 29, 2018 · 2 comments
Open

Ideas for middleware. #17

pksjce opened this issue Apr 29, 2018 · 2 comments

Comments

@pksjce
Copy link

pksjce commented Apr 29, 2018

Kudos to you for making this lib! I'm loving the mutating abilities.
I want to talk about having some middleware like abilities or hooks to the update function to implement common functionality among all mutations.
Two use cases that I wanted particularly were

  1. Logger/debug tool
  2. Crash reporter.

Did you have any plans of supporting such a thing? Would you be interested in a PR if I worked on it?

@pksjce pksjce changed the title Ideas for a middleware. Ideas for middleware. Apr 29, 2018
@aweary
Copy link
Owner

aweary commented Apr 29, 2018

I'm am definitely in favor of supporting middleware! Thanks for opening this issue, and a PR. I'll review it as soon as I can.

@pksjce
Copy link
Author

pksjce commented Apr 29, 2018

Cool! The PR is pretty raw. You may or may not approve of the approach. I will polish it up after your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants