Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployer allows generation of illegal marathon IDs #6

Open
pegelston opened this issue Nov 27, 2018 · 0 comments
Open

Deployer allows generation of illegal marathon IDs #6

pegelston opened this issue Nov 27, 2018 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@pegelston
Copy link

The deployer allows generation of illegal marathon service IDs which causes stream deployment to fail.

Expected Behavior

A stream using a label with capital letters should successfully deploy.

Current Behavior

A stream using a label with capital letters fails to deploy in marathon.

Steps to Reproduce

  1. Create a new stream in SCDF
  2. Create a label for each stream app and use capital letters, e.g. TIME: time | LOG: log
  3. Deploy the stream

Possible Solution

The deployer should sanitize the service IDs for use in marathon deployment.

Digging in, it seems that marathon restricts service IDs to the following characters:

  • digits (0-9), dashes (-)
  • dots (.)
  • lowercase letters (a-z)
  • slashes (/)
@aweigold aweigold self-assigned this Dec 21, 2018
@aweigold aweigold added this to the 2.0.0.RELEASE milestone Dec 21, 2018
@aweigold aweigold added the bug Something isn't working label Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants