Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Room Database #4

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

dungd200803btvn
Copy link

@dungd200803btvn dungd200803btvn commented Sep 1, 2024

Related Tickets

WHAT

Setup RoomDatabase, Local Resource

Evidence (Screenshot or Video)

Review Checklist

Category View Point Description Expected Reviewer Answer Self review Reviewer2 (name)
Conventions Does the code follow Sun* coding style and coding conventions? https://github.com/framgia/coding-standards/blob/master/eng/android/coding_convention_android_kotlin.md YES
  • yes
  • yes
  • Redmine Does the ticket follow Sun* Redmine working process? https://github.com/framgia/Training-Guideline/blob/master/WorkingProcess/redmine/redmine.md YES
  • yes
  • yes
  • Documentation Is there any incomplete code? If so, should it be removed or flagged with a suitable marker like ‘TODO’? YES
  • yes
  • yes
  • Notes (Optional)

    (Impacted Areas in Application(List features, api, models or services that this PR will affect))

    (Other notes)

    @daolq-2712 daolq-2712 changed the base branch from master to develop September 4, 2024 09:01
    @dungd200803btvn dungd200803btvn force-pushed the setup_db branch 3 times, most recently from e6d3334 to 692e2d8 Compare September 4, 2024 09:57
    Copy link
    Contributor

    @daolq-2712 daolq-2712 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    OK!

    @daolq-2712 daolq-2712 merged commit 4812dce into awesome-academy:develop Sep 5, 2024
    1 check passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants