Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naughty.timeout = 0 not working in request::display #3625

Open
Crylia opened this issue May 30, 2022 · 1 comment · May be fixed by #3626
Open

Naughty.timeout = 0 not working in request::display #3625

Crylia opened this issue May 30, 2022 · 1 comment · May be fixed by #3626
Milestone
v4.4

Comments

@Crylia
Copy link
Contributor

Crylia commented May 30, 2022

Output of awesome --version:

awesome v4.3-1360-gc539e0e4 (Too long)
 • Compiled against Lua 5.3.6 (running with Lua 5.3)
 • API level: 4
 • D-Bus support: yes
 • xcb-errors support: no
 • execinfo support: yes
 • xcb-randr version: 1.6
 • LGI version: 0.9.2
 • Transparency enabled: yes
 • Custom search paths: no

How to reproduce the issue:

Inside the signal request::display try to set the notification to timeout = 0

Actual result:
The timeout is not applied and the notification will run out

Expected result:

The timeout should make the notification stay indefinitely
It works when sending a notification and setting it there, but not when using this signal and setting it there.
sclu1034 added a commit to sclu1034/awesome that referenced this issue May 31, 2022
@sclu1034
fix(naughty.notification): Fix disabling timeout
9c0fa19 
When creating a notification with a timeout value of `0`, no timer is
created. The same behaviour was intended when setting the timeout to `0`
later, but it was never implemented.

Fixes awesomeWM#3625.
@sclu1034 sclu1034 linked a pull request May 31, 2022 that will close this issue
Open
@sclu1034
Copy link
Contributor

There is no connection to the request::display (or any other) signal.
This wouldn't work with just this, either:

local n = naughty.notification({ text = "test" })
n.timeout = 0

sclu1034 added a commit to sclu1034/awesome that referenced this issue Jun 28, 2022
@sclu1034
test(n.notification): Add regression test for awesomeWM#3625
140591f
@Elv13 Elv13 added this to the v4.4 milestone Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.4
Development

Successfully merging a pull request may close this issue.

Fix disabling notification timeout sclu1034/awesome
3 participants
@Elv13 @sclu1034 @Crylia