Find in the hotkeys popup

[kosorin]

Implements #3963

• find in description only
• no fuzzy or other sophisticated searching
• uses awful.prompt.run
• show_help() does not return awful.keygrabber (breaking change?)

Theme variables

Theme	Default value	Description
highlight_bg	"#ffff00"	The highlighted text background color.
highlight_fg	"#000000"	The highlighted text foreground color.
find_fg_cursor	-	The find prompt cursor foreground color.
find_bg_cursor	-	The find prompt cursor background color.
find_ul_cursor	-	The find prompt cursor underline style.
find_prompt	"<b>Find: </b>"	The find prompt text.
find_font	font	The find prompt text font.
find_margin	group_margin	Margin around the find prompt.

[actionless]

please default to other beautiful.* variables which are for sure defined in the default theme.lua instead of falling back to hardcoded colors

[kosorin]

I like this bright yellow, because the point is to easily see highlighted text. For example firefox uses #ff00ff, also bright.

What about beautiful.bg_urgent (red)? I haven't found any other beautiful colors that fit it.

[actionless]

yup, just choose any placeholder from beautiful, that bg_urgent is fine by me.
people who care more would set the right theme key anyway

[actionless]

thanks for submitting, i found small issue right from the description (and left a separate comment), i'll start reviewing the code itself later on in upcoming days or mb even hours

[actionless]

and also the test is failing:

• /home/runner/work/awesome/awesome/tests/test-awesomerc.lua: Error: running function for step 13/18 (@3): /home/runner/work/awesome/awesome/tests/test-awesomerc.lua:289: assertion failed!

[actionless]

regarding keygrabber question, i'll need first to understand:

1. what was the initial intention of returning it there
2. why it's not possible to do it anymore

[actionless]

also, mb add a bool option to args for closing hotkeys on a any keypress (the current behavior), so the users who used to that, could restore that old default behavior

[actionless]

i think find_prompt should be moved from theme option to args

[kosorin]

regarding keygrabber question, i'll need first to understand:

1. what was the initial intention of returning it there

2. why it's not possible to do it anymore

Because I use awful.prompt I no longer have access to the underlying keygrabber. Why was it returning keygrabber? I don't know, it doesn't make much sense to me.

Actually, I need to check if the prompt is stopped gracefully. Right now I just call awful.keygrabber.stop().

also, mb add a bool option to args for closing hotkeys on a any keypress (the current behavior), so the users who used to that, could restore that old default behavior

I added show_args.enable_find (enabled by default). If false, the prompt is not visible and the popup is hidden on any key.

i think find_prompt should be moved from theme option to args

I don't know. What are the odds that you want multiple prompts for different hotkey popups? It's just a simple text "find: ", nothing more so I thought was easier for user to set it once in the theme.

[actionless]

What are the odds that you want multiple prompts for different hotkey popups

it wasn't a point about having multiple different prompts, but about untying translation and style - and as you can see from our existing themes (and defined theme variables in the awful/wibox/etc builtin libraries), it's indeed not a used practice storing such sort of info there

I added show_args.enable_find (enabled by default). If false, the prompt is not visible and the popup is hidden on any key.

thanks 👍

Because I use awful.prompt I no longer have access to the underlying keygrabber. Why was it returning keygrabber? I don't know, it doesn't make much sense to me.

ok i'll try to dive into git blame to figure that out 😺

[actionless]

style checking is failing in the CI btw

[actionless]

as i mentioned in previous comment this shouldn't be defined in beautiful, as its role defining theme, not translation/labels

[actionless]

⬆️