Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENABLE_BACKTRACE option #143

Open
wants to merge 1 commit into
base: v1.x
Choose a base branch
from
Open

Conversation

ffontaine
Copy link

Allow the end-user to disable backtrace support as it raises the following build failure with https://github.com/ianlancetaylor/libbacktrace:

/home/buildroot/autobuild/run/instance-1/output-1/build/libmemcached-1.1.4/src/libmemcached/backtrace.cc: In function 'void custom_backtrace()': /home/buildroot/autobuild/run/instance-1/output-1/build/libmemcached-1.1.4/src/libmemcached/backtrace.cc:41:22: error: 'backtrace' was not declared in this scope; did you mean 'backtrace_full'?
   41 |   int stack_frames = backtrace(backtrace_buffer, MAX_DEPTH);
      |                      ^~~~~~~~~
      |                      backtrace_full
/home/buildroot/autobuild/run/instance-1/output-1/build/libmemcached-1.1.4/src/libmemcached/backtrace.cc:43:25: error: 'backtrace_symbols' was not declared in this scope; did you mean 'backtrace_syminfo'?
   43 |     char **symbollist = backtrace_symbols(backtrace_buffer, stack_frames);
      |                         ^~~~~~~~~~~~~~~~~
      |                         backtrace_syminfo

Fixes:

Allow the end-user to disable backtrace support as it raises the
following build failure with
https://github.com/ianlancetaylor/libbacktrace:

/home/buildroot/autobuild/run/instance-1/output-1/build/libmemcached-1.1.4/src/libmemcached/backtrace.cc: In function 'void custom_backtrace()':
/home/buildroot/autobuild/run/instance-1/output-1/build/libmemcached-1.1.4/src/libmemcached/backtrace.cc:41:22: error: 'backtrace' was not declared in this scope; did you mean 'backtrace_full'?
   41 |   int stack_frames = backtrace(backtrace_buffer, MAX_DEPTH);
      |                      ^~~~~~~~~
      |                      backtrace_full
/home/buildroot/autobuild/run/instance-1/output-1/build/libmemcached-1.1.4/src/libmemcached/backtrace.cc:43:25: error: 'backtrace_symbols' was not declared in this scope; did you mean 'backtrace_syminfo'?
   43 |     char **symbollist = backtrace_symbols(backtrace_buffer, stack_frames);
      |                         ^~~~~~~~~~~~~~~~~
      |                         backtrace_syminfo

Fixes:
 - http://autobuild.buildroot.org/results/3c5ee59cc032c700e01c4ac84922d749e0370a4a

Signed-off-by: Fabrice Fontaine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant