From 1fb75fdf1a9eafe6a5f213aea4e2b7574a547c9f Mon Sep 17 00:00:00 2001 From: Heather Date: Wed, 16 Oct 2024 12:18:00 -0400 Subject: [PATCH 1/3] fix clicking on current tab switching tabs --- docs/next-env.d.ts | 2 +- .../components/Authenticator/shared/SignInSignUpTabs.tsx | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/next-env.d.ts b/docs/next-env.d.ts index 4f11a03dc6c..a4a7b3f5cfa 100644 --- a/docs/next-env.d.ts +++ b/docs/next-env.d.ts @@ -2,4 +2,4 @@ /// // NOTE: This file should not be edited -// see https://nextjs.org/docs/basic-features/typescript for more information. +// see https://nextjs.org/docs/pages/building-your-application/configuring/typescript for more information. diff --git a/packages/react/src/components/Authenticator/shared/SignInSignUpTabs.tsx b/packages/react/src/components/Authenticator/shared/SignInSignUpTabs.tsx index 5fd7bfe1a2f..ae471d44cad 100644 --- a/packages/react/src/components/Authenticator/shared/SignInSignUpTabs.tsx +++ b/packages/react/src/components/Authenticator/shared/SignInSignUpTabs.tsx @@ -32,7 +32,11 @@ export const SignInSignUpTabs = ({ (route === 'signIn' ? toSignUp() : toSignIn())} + onValueChange={(prevRoute) => { + if (prevRoute !== route) { + route === 'signIn' ? toSignUp() : toSignIn(); + } + }} > {getSignInTabText()} From 657121cb05f691319356644b0ecedaedc08de722 Mon Sep 17 00:00:00 2001 From: Heather Date: Thu, 17 Oct 2024 15:24:54 -0400 Subject: [PATCH 2/3] use newRoute for route changing --- .../components/Authenticator/shared/SignInSignUpTabs.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react/src/components/Authenticator/shared/SignInSignUpTabs.tsx b/packages/react/src/components/Authenticator/shared/SignInSignUpTabs.tsx index ae471d44cad..fb0f01bd559 100644 --- a/packages/react/src/components/Authenticator/shared/SignInSignUpTabs.tsx +++ b/packages/react/src/components/Authenticator/shared/SignInSignUpTabs.tsx @@ -32,9 +32,9 @@ export const SignInSignUpTabs = ({ { - if (prevRoute !== route) { - route === 'signIn' ? toSignUp() : toSignIn(); + onValueChange={(newRoute) => { + if (newRoute !== route) { + newRoute === 'signIn' ? toSignIn() : toSignUp(); } }} > From 21e1e12d57b5132a95e3e5945622216ad341455b Mon Sep 17 00:00:00 2001 From: Heather Buchel Date: Thu, 17 Oct 2024 15:51:18 -0400 Subject: [PATCH 3/3] Create brown-pumpkins-knock.md --- .changeset/brown-pumpkins-knock.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/brown-pumpkins-knock.md diff --git a/.changeset/brown-pumpkins-knock.md b/.changeset/brown-pumpkins-knock.md new file mode 100644 index 00000000000..3cfc9e06339 --- /dev/null +++ b/.changeset/brown-pumpkins-knock.md @@ -0,0 +1,5 @@ +--- +"@aws-amplify/ui-react": patch +--- + +fix(React/Authenticator): clicking on currently active tab no longer switches to the wrong tab