Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update equals is useful for always false #3855

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Dec 5, 2024

Issue #, if available:
fix #3846
Description of changes:

  • Update equals is useful for always false

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.78%. Comparing base (58dc21c) to head (850b768).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3855      +/-   ##
==========================================
+ Coverage   93.73%   93.78%   +0.05%     
==========================================
  Files         364      364              
  Lines       12458    12463       +5     
  Branches     2419     2556     +137     
==========================================
+ Hits        11677    11688      +11     
+ Misses        430      429       -1     
+ Partials      351      346       -5     
Flag Coverage Δ
unittests 93.74% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 19192ef into aws-cloudformation:main Dec 5, 2024
24 checks passed
@kddejong kddejong deleted the fix/issue/3846 branch December 5, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

W8003 (Fn::Equals will always return true or false) doesn't validate if Fn::Equals will always return false
1 participant