Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to raising bad path errors #3862

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Dec 9, 2024

Issue #, if available:
fix #3827

Description of changes:

  • Switch back to raising bad bath errors
  • in pr Fail gracefully if no templates match wildcard #3603 we stopped failing if a template file was not found. This brings back that functionality but additionally allows a person to use the parameter ignore_bad_templates that will ignore if the path is bad.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.81%. Comparing base (30ecbc1) to head (88a9e5f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3862      +/-   ##
==========================================
+ Coverage   93.80%   93.81%   +0.01%     
==========================================
  Files         364      365       +1     
  Lines       12497    12508      +11     
  Branches     2568     2568              
==========================================
+ Hits        11723    11735      +12     
+ Misses        429      428       -1     
  Partials      345      345              
Flag Coverage Δ
unittests 93.77% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DeflateAwning
Copy link

FYI - Typo in PR name (bath vs path)

@kddejong kddejong changed the title Switch back to raising bad bath errors Switch back to raising bad path errors Dec 9, 2024
@kddejong kddejong merged commit c6e3878 into aws-cloudformation:main Dec 10, 2024
25 checks passed
@kddejong kddejong deleted the fix/issue/3827 branch December 10, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running cfn-lint file_that_does_not_exist.yml has exit code 0 and no error message
2 participants