Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong code in Service Autoscaling #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

palateo93
Copy link

The service autoscaling does not use self.fargate_load_balanced_service which is required.


Description of changes:
If you just uncomment the code below the comment "Enable Service Autoscaling" it does not work throwing the following error:

Traceback (most recent call last):
  File "/home/ec2-user/environment/ecsdemo-frontend/cdk/app.py", line 349, in <module>
    FrontendService(app, stack_name, env=_env)
  File "/home/ec2-user/.local/lib/python3.9/site-packages/jsii/_runtime.py", line 118, in __call__
    inst = super(JSIIMeta, cast(JSIIMeta, cls)).__call__(*args, **kwargs)
  File "/home/ec2-user/environment/ecsdemo-frontend/cdk/app.py", line 94, in __init__
    self.autoscale = fargate_load_balanced_service.service.auto_scale_task_count(
NameError: name 'fargate_load_balanced_service' is not defined

This is because it does not point to self.fargate_load_balanced_service.service.auto_scale_task_count


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

The service autoscaling does not use `self.fargate_load_balanced_service` which is required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant