Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch template #1952

Closed
speedfl opened this issue Dec 6, 2023 · 5 comments
Closed

Launch template #1952

speedfl opened this issue Dec 6, 2023 · 5 comments
Labels
kind/new-resource Categorizes issue or PR as related to a new resource. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. service/eks Indicates issues or PRs that are related to eks-controller.

Comments

@speedfl
Copy link

speedfl commented Dec 6, 2023

Is your feature request related to a problem?
When using EKS node groups the tags are not propagated to the instances. For that you need to specify a launch template.
https://doc.crds.dev/github.com/aws-controllers-k8s/eks-controller/eks.services.k8s.aws/Nodegroup/[email protected]

This launch template cannot be created using the controller which makes it unusabled when you need to add dedicated tags

Describe the solution you'd like
launch template should be created using the controller and then referenced using NodeGroup

Describe alternatives you've considered
Crossplane is proposing this feature.

@a-hilaly a-hilaly added service/eks Indicates issues or PRs that are related to eks-controller. kind/new-resource Categorizes issue or PR as related to a new resource. labels Dec 7, 2023
@a-hilaly
Copy link
Member

We already have two PRs introducing EC2 Launch templates and Launch templates versions. Once these are merged we can enable cross-controller resources references for this field

@ack-bot
Copy link
Collaborator

ack-bot commented Jun 28, 2024

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 28, 2024
@ack-bot
Copy link
Collaborator

ack-bot commented Aug 27, 2024

Stale issues rot after 60d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 60d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle rotten

@ack-prow ack-prow bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 27, 2024
@ack-bot
Copy link
Collaborator

ack-bot commented Oct 26, 2024

Rotten issues close after 60d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

@ack-prow ack-prow bot closed this as completed Oct 26, 2024
Copy link

ack-prow bot commented Oct 26, 2024

@ack-bot: Closing this issue.

In response to this:

Rotten issues close after 60d of inactivity.
Reopen the issue with /reopen.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/new-resource Categorizes issue or PR as related to a new resource. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. service/eks Indicates issues or PRs that are related to eks-controller.
Projects
None yet
Development

No branches or pull requests

3 participants