Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iam_role_additional_policies #34

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Fix iam_role_additional_policies #34

merged 3 commits into from
Jun 19, 2023

Conversation

SamuZad
Copy link
Contributor

@SamuZad SamuZad commented May 31, 2023

What does this PR do?

Inspired by a detailed bug report, I implemented the proposed change to iam_role_additional_policies.

  • The type of the variable is changed
  • The conditional evaluating whether it is necessary to use the variable has been updated
  • The documentation has been updated to reflect the change
  • The example was updated to show iam_role_additional_policies in action
  • Fixed an extra typo regarding subnets in the example

Motivation

A fix for #30

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@SamuZad SamuZad requested review from a team and vara-bonthu as code owners May 31, 2023 11:00
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamuZad Thanks for the PR 🚀 LGTM 👍🏼

@vara-bonthu vara-bonthu merged commit d5b685b into aws-ia:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants