Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove s3 arn variable as a requirement #36

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

fossouo
Copy link

@fossouo fossouo commented Jul 25, 2023

What does this PR do?

remove need of s3 arn variable, the data module provides the capability to get s3 arn from S3 Bucket Name

Motivation

This pull request will improve usage of MWAA Module

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I ran pre-commit run -a with this PR

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

fossouo added 2 commits July 25, 2023 09:54
remove need of s3 arn variable, the data module provides the capability to get s3 arn from S3 Bucket Name
remove need of s3 arn variable, the data module provides the capability to get s3 arn from S3 Bucket Name
@fossouo fossouo requested review from a team and vara-bonthu as code owners July 25, 2023 07:58
@vara-bonthu
Copy link
Collaborator

Thanks for the PR👍 Could you please create an issue to support this PR and add more details about this enhancement. Did the previous approach caused any issue?

@fossouo
Copy link
Author

fossouo commented Jul 25, 2023

Thanks for the PR👍 Could you please create an issue to support this PR and add more details about this enhancement. Did the previous approach caused any issue?

I have create an issue here : #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants