Skip to content

Commit

Permalink
Workaround requests issue (#191)
Browse files Browse the repository at this point in the history
See
#188
for context on the bug itself. The problem is that contract tests have
transitive dependency on `requests~=2.7`, which pulls in 2.32.0, which
has an issue with current version of docker. To fix this, we temporarily
take a hard dependency on 2.31.0, which does not have the issue. This
code can be removed once we upgrade successfully to 2.32.0.


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
  • Loading branch information
thpierce authored May 22, 2024
1 parent 9041a31 commit 2f9f42a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion contract-tests/tests/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ dependencies = [
"testcontainers==3.7.1",
"grpcio==1.60.0",
"docker==7.0.0",
"mock-collector==1.0.0"
"mock-collector==1.0.0",
"requests==2.31.0"
]

[project.optional-dependencies]
Expand Down

0 comments on commit 2f9f42a

Please sign in to comment.