Make region limitation more clear #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using a CloudFormation rule, the user can receive feedback more quickly. The error message is also more helpful.
svozza
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This template can only be deployed in the
us-east-1region.See #19 for discussion about this limitation and possible alternatives.
This PR adds two features intended to improve the user experience
us-east-1us-east-1. If the user tries to deploy the template outside ofus-east-1, this rule will cause the deployment to fail. This has two advantages over letting the deployment fail later due to the ACM/CloudFront limitationI'd appreciate suggestions on how to make the
AssertDescriptionas helpful as possible. This is the message shown in the CloudFormation logs when the region rule causes the template to fail.Here's an example of what it looks like in the logs.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.