Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The documentation is wrong about ELB_LIST #38

Open
techgnosis opened this issue Feb 18, 2016 · 4 comments
Open

The documentation is wrong about ELB_LIST #38

techgnosis opened this issue Feb 18, 2016 · 4 comments
Labels

Comments

@techgnosis
Copy link

You don't need to edit ELB_LIST anymore. There is a method in common_functions.sh that populates it for you.

@johnwheal
Copy link

Thanks, you saved me a lot of time by posting this - AWS should probably update the docs

@nwalke
Copy link
Contributor

nwalke commented Apr 25, 2016

Correct me if I'm wrong... but we still need to manually call this from somewhere, right?

@techgnosis
Copy link
Author

You need to call the register/deregister scripts but you don't need to set
ELB_LIST before you do it
On Apr 25, 2016 7:27 AM, "Nick Walke" [email protected] wrote:

Correct me if I'm wrong... but we still need to manually call this from
somewhere, right?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#38 (comment)

@wjordan
Copy link

wjordan commented May 12, 2016

To clarify:

  • You do not need to set ELB_LIST at all if your instances are a part of an Auto Scaling Group.
  • You do need to set ELB_LIST if your instances are registered with load balancer(s) manually.
  • The get_elb_list function in common_functions.sh will populate ELB_LIST for you. However, there are currently issues (see my PR Fix get_elb_list function when looking up from ELB #41 for a fix).
  • I've submitted a PR automatically set ELB_LIST if not provided #40 to use get_elb_list to automatically populate ELB_LIST for you as long as you set ELB_LIST to all.

@Jmcfar Jmcfar added the bug label Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants