Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #85 #88

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Fixes #85 #88

merged 2 commits into from
Apr 26, 2024

Conversation

sarika-subram
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #85

Type of change

Please delete options that are not relevant, and add any that may be relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Single Account, Single Service and Single Region
  • Single Account, Single Service and Multiple Regions
  • Single Account, Multiple Services and Single Region
  • Single Account, Multiple Services and Multiple Regions
  • CrossAccounts, Multiple Services and Multiple Regions

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this change with all regions and services
  • Any dependent changes have been merged and published in downstream modules

@sarika-subram sarika-subram merged commit 60ea2ac into aws-samples:main Apr 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enableGuardDuty finding labelled wrongly as Cost Optimization pillar
1 participant