Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print out the name of the SNS topic that a Notification is published to for clarity in the logs #183

Open
thesuavehog opened this issue Dec 13, 2023 · 1 comment
Open

Print out the name of the SNS topic that a Notification is published to for clarity in the logs #183

thesuavehog opened this issue Dec 13, 2023 · 1 comment
Labels
enhancement New feature or request triaged Has been triaged by solutions team

Comments

@thesuavehog
Copy link

Is your feature request related to a problem? Please describe.

When debugging issues with the solution, the logging is not identifying the SNS topic that is being used which makes it extra work to debug.

Describe the feature you'd like

When delivering a notification and logging the delivery success, include the SNS Topic that was used to send the message.

This happens in the sechub_findings.py script
@thesuavehog thesuavehog added the enhancement New feature or request label Dec 13, 2023
thesuavehog added a commit to thesuavehog/automated-security-response-on-aws that referenced this issue Dec 13, 2023
@thesuavehog
fix Print out the name of the SNS topic that a Notification is publis…
67483da 
…hed to for clarity in the logs aws-solutions#183
@thesuavehog thesuavehog mentioned this issue Dec 13, 2023
Open
@tmekari tmekari added the triaged Has been triaged by solutions team label Dec 18, 2023
@tmekari
Copy link
Contributor

tmekari commented Dec 18, 2023

Hi Jeff, thank you for your contributions! We will take a look and consider this for our next release, thanks again for your input on enhancing the solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triaged Has been triaged by solutions team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmekari @thesuavehog