Add E2E EKS Terraform environment. #430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musa-asad
commented
Nov 14, 2024
Paramadon
reviewed
Nov 15, 2024
Paramadon
reviewed
Nov 15, 2024
Paramadon
reviewed
Nov 15, 2024
Paramadon
reviewed
Nov 15, 2024
Paramadon
reviewed
Nov 15, 2024
movence
reviewed
Nov 15, 2024
|
looks like you need to rebase |
okankoAMZ
reviewed
Nov 15, 2024
There was a problem hiding this comment.
The PR aims to add an E2E EKS test environment, which is a valuable addition. However, it includes some changes that may not be directly related to this goal, such as helm install commands and sample applications.
Could you clarify the reasoning behind these additions or consider separating them into a different PR if they're not essential for the E2E EKS environment?
okankoAMZ
reviewed
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was moved to #434 in order to be able to call it as a feature branch from the GitHub workflow from the
amzon-cloudwatch-agentrepo.