Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus] agent is printing all the scraped metrics in log #209

Closed
pingleig opened this issue May 18, 2021 · 1 comment
Closed

[prometheus] agent is printing all the scraped metrics in log #209

pingleig opened this issue May 18, 2021 · 1 comment
Assignees
Labels
bug Something isn't working component/prometheus Prometheus
Milestone

Comments

@pingleig
Copy link
Member

Overview

The latest version of docker image is printing all the metrics into its own log, the root cause is in #193 where @pingleig forgot to remove the debug statement ae64a26#r50943644

log.Printf("%s %v", pm.metricName, labelMap)

What should you do

  • If you are only using prometheus part of the agent, you can safely revert back to previous version unless you are relabelling job, instance or __name__ (see Versions section for yaml and docker image you should use).
  • If you are not using prometheus part of the agent or not collecting log of agent itself, you won't get billed for the large amount (useless) log, though it will add some pressure on the node running agent depends the volume of prometheus metrics.
  • If you are using agent for collecting container metrics on EKS, agent is using cadvisor and not using prometheus. And if you uses contianerd, only the latest release contains [k8s] Pod metrics is gone when using containerd as runtime #188 so you should stick with the lastest version.

Versions

Previous version

Latest version (w/ the log bug)

@pingleig
Copy link
Member Author

Fixed in latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/prometheus Prometheus
Projects
None yet
Development

No branches or pull requests

1 participant