implemented some of modulitos' review proposals

aws · Aug 29, 2024 · e20c44f · e20c44f
1 parent fe74545
commit e20c44f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pkg/cache/cache.go b/pkg/cache/cache.go
@@ -61,7 +61,7 @@ type Response struct {
 	TokenExpiration int64
 	FoundInSACache  bool
 	FoundInCMCache  bool
-	Notifier        chan struct{}
+	Notifier        <-chan struct{}
 }
 
 type ServiceAccountCache interface {

diff --git a/pkg/cache/cache_test.go b/pkg/cache/cache_test.go
@@ -126,6 +126,8 @@ func TestNotification(t *testing.T) {
 		for i := 0; i < 10; i++ {
 			wg.Add(1)
 			go func() {
+				defer wg.Done()
+
 				// wait for the notification
 				select {
 				case <-resp.Notifier:
@@ -136,7 +138,6 @@ func TestNotification(t *testing.T) {
 				case <-time.After(1 * time.Second):
 					t.Error("timeout waiting for notification")
 				}
-				wg.Done()
 			}()
 		}