Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable log output for the aws-eks-nodeagent in the daemonset #2843

Closed
OcamsRazor opened this issue Mar 12, 2024 · 3 comments
Closed

Configurable log output for the aws-eks-nodeagent in the daemonset #2843

OcamsRazor opened this issue Mar 12, 2024 · 3 comments

Comments

@OcamsRazor
Copy link

What would you like to be added:

Hi, I'm wondering if it would be possible to add support for the --log-file argument on the aws-eks-nodeagent container to set /dev/stdout as the log output.
I have found following comment aws/aws-network-policy-agent#50 (comment) but seems this is not yet possible.

I'm deploying the VPC CNI using TF (aws_eks_addon). Is the JSON schema that is used for configuration generated based on the values.yaml file of this chart ?

Why is this needed:

Agent logs and policy decision logs are by default stored in /var/log/aws-routed-eni/network-policy-agent.log. For log scraping with e.g. fluent-bit, pods need to be privileged to gain access to the log file.
Writing logs to stdout would enable standard log tooling to be used

Thanks

@orsenthil
Copy link
Member

The flag https://github.com/aws/aws-network-policy-agent/blob/main/pkg/config/controller_config.go#L10 is configurable via --log-file. It looks like we aren't exposing this in the helm chart here - https://github.com/aws/amazon-vpc-cni-k8s/tree/master/charts/aws-vpc-cni

This needs to be added.

@orsenthil
Copy link
Member

This PR will resolve this - #2925

Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants