Enhance subnet selection #2714
Merged
Enhance subnet selection #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchen6585
commented
Dec 18, 2023
jdn5126
reviewed
Dec 21, 2023
test/integration/eni-subnet-selection/eni_subnet_selection_test.go
Outdated
Show resolved
Hide resolved
test/integration/eni-subnet-selection/eni_subnet_selection_test.go
Outdated
Show resolved
Hide resolved
jchen6585
force-pushed
the
subnet-selection
branch
from
d63b57f
to
7fe0020
Compare
This was referenced Dec 26, 2023
jchen6585
force-pushed
the
subnet-selection
branch
4 times, most recently
from
1eb45d1
to
b4ef564
Compare
jdn5126
reviewed
Jan 3, 2024
test/integration/eni-subnet-selection/eni_subnet_selection_test.go
Outdated
Show resolved
Hide resolved
jchen6585
force-pushed
the
subnet-selection
branch
2 times, most recently
from
c2a240e
to
b8d8cac
Compare
jchen6585
force-pushed
the
subnet-selection
branch
from
b8d8cac
to
1328acf
Compare
jchen6585
force-pushed
the
subnet-selection
branch
2 times, most recently
from
8f5e160
to
7917117
Compare
jayanthvn
reviewed
Feb 1, 2024
jayanthvn
reviewed
Feb 1, 2024
jayanthvn
reviewed
Feb 1, 2024
jayanthvn
reviewed
Feb 1, 2024
jayanthvn
reviewed
Feb 1, 2024
jayanthvn
reviewed
Feb 1, 2024
jayanthvn
reviewed
Feb 1, 2024
jayanthvn
reviewed
Feb 6, 2024
ellistarn
reviewed
Feb 9, 2024
ellistarn
reviewed
Feb 9, 2024
jdn5126
reviewed
Feb 15, 2024
jchen6585
force-pushed
the
subnet-selection
branch
3 times, most recently
from
f1d888d
to
868c847
Compare
jchen6585
force-pushed
the
subnet-selection
branch
from
868c847
to
3551e7e
Compare
jayanthvn
reviewed
Mar 9, 2024
jayanthvn
reviewed
Mar 9, 2024
jayanthvn
reviewed
Mar 9, 2024
jchen6585
force-pushed
the
subnet-selection
branch
3 times, most recently
from
5bc3fdd
to
ef5d3c3
Compare
jayanthvn
reviewed
Mar 13, 2024
jayanthvn
reviewed
Mar 13, 2024
jchen6585
commented
Mar 13, 2024
jchen6585
force-pushed
the
subnet-selection
branch
from
ef5d3c3
to
55aabfb
Compare
jayanthvn
reviewed
Mar 14, 2024
jayanthvn
reviewed
Mar 14, 2024
jayanthvn
reviewed
Mar 14, 2024
| } else { | ||
| if cache.useSubnetDiscovery { | ||
| subnetResult, vpcErr := cache.getVpcSubnets() | ||
| if vpcErr != nil { |
There was a problem hiding this comment.
Maybe as a fast follow up lets restructure the code..
- Get subnet -> Either primary ENI, ENIConfig or pick a subnet
- Get SG -> Either primary ENI SG or ENIConfig SG
- Modify the "input" with the new subnet ID and SG ID
- Call tryCreateNetworkInterface
jayanthvn
reviewed
Mar 14, 2024
jchen6585
force-pushed
the
subnet-selection
branch
3 times, most recently
from
6cb6e9b
to
29fabc8
Compare
jchen6585
force-pushed
the
subnet-selection
branch
from
29fabc8
to
cd263e8
Compare
achevuru
approved these changes
Mar 15, 2024
alex-zige
reviewed
May 2, 2024
| []string{createdSubnet}, | ||
| []*ec2.Tag{ | ||
| { | ||
| Key: aws.String("kubernetes.io/role/cn"), |
There was a problem hiding this comment.
I think, it is alright. The tagging and un-tagging was consistent in this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
IP exhaustion in IPv4 is a prevalent issue. This PR helps with this by creating ENIs using all subnets in the VPC with the correct tags.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Integration
Upgrade/Downgrade
aws-nodepodPerformance Test
Will this PR introduce any new dependencies?:
Yes
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No, Yes
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
Yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.