Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Pick default envoy, proxyInit & controller image repository based on the region #557

Open
suniltheta opened this issue Jan 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@suniltheta
Copy link
Contributor

Is your feature request related to a problem?
Today the Controller (link), Envoy (link) & proxy init (link) images are hardcoded to download docker images from us-west-2 region.

Since all these three images are available globally can we make these default values as default and pick the image from the region where the cluster is deployed?

Especially in China partition we have to manually go and set the image repository where we want to pick the images from, other wise K8s controller will not pull the image deployed in region 'us-west-2' from inside cluster running in China partition.

Image Parameter Default today New Default Accounts to pick from
AppMesh K8s Controller image.repository 602401143452.dkr.ecr.us-west-2.amazonaws.com/amazon/appmesh-controller default link
AppMesh Envoy sidecar sidecar.image.repository 840364872350.dkr.ecr.us-west-2.amazonaws.com/aws-appmesh-envoy default link
Proxy Route Manager init.image.repository 840364872350.dkr.ecr.us-west-2.amazonaws.com/aws-appmesh-proxy-route-manager default link

Describe the solution you'd like
Based on the region the cluster is deployed we pull the image from that particular region. Otherwise user has to manually set these --set *.image.repository to pick from the region they want.

Describe alternatives you've considered
NA

@suniltheta suniltheta added the enhancement New feature or request label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant