address second round of feedback, includes tests

aws · May 19, 2024 · 0119392 · 0119392
1 parent 0b4bbea
commit 0119392
Show file tree

Hide file tree

Showing 3 changed files with 427 additions and 5 deletions.
diff --git a/pkg/aws/services/tagging.go b/pkg/aws/services/tagging.go
@@ -129,7 +129,7 @@ func (t *latticeTagging) FindResourcesByTags(ctx context.Context, resourceType R
 			return nil, err
 		}
 
-		if containsTags(tags, resp.Tags) {
+		if containsTags(resp.Tags, tags) {
 			arns = append(arns, aws.StringValue(tg.Arn))
 		}
 	}
@@ -138,8 +138,9 @@ func (t *latticeTagging) FindResourcesByTags(ctx context.Context, resourceType R
 }
 
 func containsTags(source, check Tags) bool {
-	for k, v := range source {
-		if aws.StringValue(check[k]) != aws.StringValue(v) {
+	for k, v := range check {
+		sourceV, ok := source[k]
+		if !ok || aws.StringValue(sourceV) != aws.StringValue(v) {
 			return false
 		}
 	}