Code cleanup

aws · Oct 12, 2023 · 40dc546 · 40dc546
1 parent 840441f
commit 40dc546
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/pkg/aws/services/vpclattice.go b/pkg/aws/services/vpclattice.go
@@ -30,7 +30,7 @@ type defaultLatticeServiceNameProvider struct {
 	name string
 }
 
-func NewLatticeServiceNameProvider(name string) LatticeServiceNameProvider {
+func NewDefaultLatticeServiceNameProvider(name string) *defaultLatticeServiceNameProvider {
 	return &defaultLatticeServiceNameProvider{
 		name: name,
 	}

diff --git a/pkg/deploy/lattice/access_log_subscription_manager.go b/pkg/deploy/lattice/access_log_subscription_manager.go
@@ -49,7 +49,7 @@ func (m *defaultAccessLogSubscriptionManager) Create(
 		}
 		resourceIdentifier = *serviceNetwork.SvcNetwork.Arn
 	case lattice.ServiceSourceType:
-		serviceNameProvider := services.NewLatticeServiceNameProvider(accessLogSubscription.Spec.SourceName)
+		serviceNameProvider := services.NewDefaultLatticeServiceNameProvider(accessLogSubscription.Spec.SourceName)
 		service, err := vpcLatticeSess.FindService(ctx, serviceNameProvider)
 		if err != nil {
 			return nil, err

diff --git a/pkg/deploy/lattice/access_log_subscription_manager_test.go b/pkg/deploy/lattice/access_log_subscription_manager_test.go
@@ -82,7 +82,7 @@ func Test_Create_NewAccessLogSubscriptionForService_ReturnsSuccess(t *testing.T)
 			IsDeleted:      false,
 		},
 	}
-	serviceNameProvider := services.NewLatticeServiceNameProvider(sourceName)
+	serviceNameProvider := services.NewDefaultLatticeServiceNameProvider(sourceName)
 	findServiceOutput := &vpclattice.ServiceSummary{
 		Arn:  aws.String(serviceArn),
 		Name: aws.String(sourceName),
@@ -160,7 +160,7 @@ func Test_Create_NewAccessLogSubscriptionForDeletedService_ReturnsNotFoundError(
 			IsDeleted:      false,
 		},
 	}
-	serviceNameProvider := services.NewLatticeServiceNameProvider(sourceName)
+	serviceNameProvider := services.NewDefaultLatticeServiceNameProvider(sourceName)
 	findServiceOutput := &vpclattice.ServiceSummary{
 		Arn:  aws.String(serviceArn),
 		Name: aws.String(sourceName),
@@ -380,7 +380,7 @@ func Test_Create_NewAccessLogSubscriptionForMissingService_ReturnsNotFoundError(
 		},
 	}
 	notFoundErr := services.NewNotFoundError("", "")
-	serviceNameProvider := services.NewLatticeServiceNameProvider(sourceName)
+	serviceNameProvider := services.NewDefaultLatticeServiceNameProvider(sourceName)
 
 	mockLattice.EXPECT().FindService(ctx, serviceNameProvider).Return(nil, notFoundErr)
 	mockCloud.EXPECT().Lattice().Return(mockLattice).AnyTimes()

diff --git a/...ration/access_log_policy_creation_test.go → ...tes/integration/access_log_policy_test.go b/...ration/access_log_policy_creation_test.go → ...tes/integration/access_log_policy_test.go