Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miss to add the DISABLE_TAGGING_SERVICE_API envvariable in the environment.md, helm/templates/deployment.yaml and helm/values.yaml #653

Open
zijun726911 opened this issue Jun 14, 2024 · 0 comments

Comments

@zijun726911
Copy link
Contributor

zijun726911 commented Jun 14, 2024

In this PR we add the DISABLE_TAGGING_SERVICE_API env variable https://github.com/aws/aws-application-networking-k8s/pull/627/files

However we miss to add corresponding env variable in the environment.md, helm/templates/deployment.yaml and helm/values.yaml and the users cannot pass that env variable to start the helm chart.

value: {{ .Values.webhookEnabled | quote }}

as the Helm install will also generate the necessary certificate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant