Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cli): remove quiet flag from SdkProvider.forEnvironment #32233

Open
mrgrain opened this issue Nov 21, 2024 · 0 comments
Open

(cli): remove quiet flag from SdkProvider.forEnvironment #32233

mrgrain opened this issue Nov 21, 2024 · 0 comments
Labels
@aws-cdk/core Related to core CDK functionality p2

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Nov 21, 2024

SdkProvider.forEnvironment has a quiet flag which seems to only exist for the integration with cdk-assets.
This is the only one place that flag is used to set it to a different value than the default:
https://github.com/aws/aws-cdk/blob/5178050dc318fb0dc643bc208af553adb8245bc5/packages/aws-cdk/lib/util/asset-publishing.ts

The flag itself is the same that is passed to cdk-assets, so we only can do this once cdklabs/cdk-assets#196 is completed.

We don't want flags to be passed around. Instead everything is always logged with the same log level and the logger than decides if a message needs printing or not.

Expected Behavior

All output is always "logged" with a log level.
Use the log level as defined by the CLI.

Current Behavior

Output is logged or not depending on the flag.

@mrgrain mrgrain added p2 @aws-cdk/core Related to core CDK functionality labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/core Related to core CDK functionality p2
Projects
None yet
Development

No branches or pull requests

1 participant