Missing "imagePullSecrets" field in Cloudwatch metrics helm templates definition (daemonset.yaml) #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added imagePullSecrets field in definition
added missing value imagePullSecrets: []
updated Read me with imagePullSecret information
Incrementing Chart version in chart yaml for imagepullsecret field change
|
@bwagner5 Could you please have a check? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Not AvailableDescription of changes
imagePullSecrets field is missing in daemonset.yaml in https://github.com/aws/eks-charts/blob/master/stable/aws-cloudwatch-metrics/templates/daemonset.yaml. I have added this definition and also updated values.yaml accordingly here - https://github.com/aws/eks-charts/blob/master/stable/aws-cloudwatch-metrics/values.yamlChecklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)Testing
Downloaded the chart and updated the field of imagePullSecret and pushed the helm chart to private helm repo and using this installed the helm chart for aws-cloudwatch-metrics with imagepullsecret value and its working fine.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.