Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional args to be passed to the command #1047

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sitilge
Copy link

@sitilge sitilge commented Jan 11, 2024

Issue

Description of changes

This small change allows additional args to be passed to the command. It is useful in automation and can be used to bypass the currently hardcoded args. The AWS EBS CSI driver helm chart has exactly the same functionality: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/3981294942b4aa3bdfac95a06d7ab57b43c8130d/charts/aws-ebs-csi-driver/templates/controller.yaml#L103C1-L105C23

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

I manually ran the helm template --debug command and passed the new additionalArgs field.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sitilge sitilge requested a review from M00nF1sh as a code owner January 11, 2024 20:24
@sitilge
Copy link
Author

sitilge commented Aug 12, 2024

@M00nF1sh what do you think about this additional args flag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants