Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart variable to specify webhook annotations #1106

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ankursgupta87
Copy link

Issue

Description of changes

This PR adds an option in aws-load-balancer-controller helm chart to specify extra annotations to both mutating and validating webhook.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ankursgupta87 ankursgupta87 requested a review from M00nF1sh as a code owner May 18, 2024 11:27
@ankursgupta87
Copy link
Author

/assign @jayanthvn

@ankursgupta87
Copy link
Author

@M00nF1sh @jayanthvn can you guys PTAL at this? It’s a minor change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant