Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update values.yaml #1129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update values.yaml #1129

wants to merge 1 commit into from

Conversation

bluecrayon52
Copy link

Appended ml. prefix instances to the values list for compatibility with SageMaker instances.

Issue

Description of changes

The SageMaker HyperPod team is conducting internal development work that requires the use of the EFA K8s device plugin with ml. prefixed instances. I've appended a list of ml. prefix instances to the values list for compatibility with SageMaker instances.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

I've tested this, but cannot give specifics because the details are strictly internal. message me on the Amazon Slack workspace @natharno for details.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Appended ml. prefix instances to the values list for compatibility with SageMaker instances.
@bluecrayon52 bluecrayon52 requested a review from bwagner5 as a code owner July 2, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant