Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure s2n-tls and rustls agree on event order #2373

Open
camshaft opened this issue Nov 8, 2024 · 0 comments
Open

Ensure s2n-tls and rustls agree on event order #2373

camshaft opened this issue Nov 8, 2024 · 0 comments

Comments

@camshaft
Copy link
Contributor

camshaft commented Nov 8, 2024

Problem:

Currently, s2n-tls and rustls emit the TLS events in a different order, which can cause issues for event subscribers expecting a certain order for both.

Currently the SNI and ALPN are in different orders:

https://docs.rs/s2n-quic/latest/s2n_quic/provider/event/trait.Subscriber.html#method.on_application_protocol_information
https://docs.rs/s2n-quic/latest/s2n_quic/provider/event/trait.Subscriber.html#method.on_server_name_information

Solution:

We should make sure the event order is the same between both. We should have tests in place showing that they are the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant