Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing s2n-quic-xdp crate fails due to MSRV #2440

Closed
jouho opened this issue Jan 8, 2025 · 1 comment
Closed

Publishing s2n-quic-xdp crate fails due to MSRV #2440

jouho opened this issue Jan 8, 2025 · 1 comment

Comments

@jouho
Copy link
Contributor

jouho commented Jan 8, 2025

Problem:

When publishing the xdp crate, I get the following error:

ubuntu@:~/s2n-quic$ cargo publish --manifest-path tools/xdp/s2n-quic-xdp/Cargo.toml -p s2n-quic-xdp
    Updating crates.io index
   Packaging s2n-quic-xdp v0.52.0 (/home/ubuntu/s2n-quic/tools/xdp/s2n-quic-xdp)
   Verifying s2n-quic-xdp v0.52.0 (/home/ubuntu/s2n-quic/tools/xdp/s2n-quic-xdp)
    Updating crates.io index
error: failed to verify package tarball

Caused by:
  package `aya v0.13.1` cannot be built because it requires rustc 1.80.0 or newer, while the currently active rustc version is 1.74.1

This is because we set the publish version to use 1.80.0 rustc version:

channel = "1.80.0"

Solution:

Upgrade MSRV to 1.80.0. This was overriding the rustc version used when publishing:

ubuntu@:~/s2n-quic$ rustup default 1.80.0
info: using existing install for '1.80.0-x86_64-unknown-linux-gnu'
info: default toolchain set to '1.80.0-x86_64-unknown-linux-gnu'

  1.80.0-x86_64-unknown-linux-gnu unchanged - rustc 1.80.0 (051478957 2024-07-21)

info: note that the toolchain '1.74.1-x86_64-unknown-linux-gnu' is currently in use (overridden by '/home/ubuntu/s2n-quic/rust-toolchain')

Upgrading MSRV to 1.80.0 also allows us to resolve #2334

Requirements / Acceptance Criteria:

Out of scope:

@jouho jouho changed the title publishing s2n-quic-xdp crate fails due to MSRV Publishing s2n-quic-xdp crate fails due to MSRV Jan 8, 2025
@camshaft
Copy link
Contributor

camshaft commented Jan 9, 2025

When publishing, you need to pushd/popd into the crate directory instead of --manifest-dir. This will use the appropriate rust-toolchain:

https://github.com/aws/s2n-quic/blob/2f357d5f31bec6deff82ea8f29df095cfee6f026/tools/xdp/rust-toolchain#L2C6-L2C19

@camshaft camshaft closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants