Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: random fixes #33

Merged
merged 1 commit into from
Jul 15, 2020
Merged

ci: random fixes #33

merged 1 commit into from
Jul 15, 2020

Conversation

camshaft
Copy link
Contributor

@camshaft camshaft commented Jul 15, 2020

Changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@camshaft camshaft marked this pull request as ready for review July 15, 2020 21:43
Copy link
Contributor

@dougch dougch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; curious about the timing impact of removing sccache though?

@camshaft
Copy link
Contributor Author

It doesn't hurt us too much on this one, since we're not actually building anything (it's using cargo check if I'm not mistaken).

@camshaft camshaft merged commit c472f60 into master Jul 15, 2020
@camshaft camshaft deleted the ci-fixes branch July 15, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants